[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: When Pull Requests wedge...???



I have increased the time we wait for GitHub to be correct on mergeability up to 2 hours.  It was 30 mins before.  That's 40 consecutive checks we would make and every time GitHub has to tell us a request isn't mergeable before we will update the pull request with a comment stating so.

-Dan

----- Original Message -----
> 
> 
> ----- Original Message -----
> > +++ Mark Lamourine [05/03/13 08:20 -0500]:
> > >I have several pull requests pending that are getting notices from
> > >the openshift-bot indicating some kind of incomplete test/merge
> > >state:
> > >
> > > "evaluated to <commitid>"
> > >
> > > "Origin Action Required: Pull request cannot be automatically
> > > merged",
> > >
> > >However, unless there's an actual test fail there's no pointer in
> > >the email or pull-request note indicating where to look to
> > >understand the problem.  It's not clear what the issue is let
> > >alone
> > >how to address it.
> > >
> > >Is there a place to look which will indicate what caused the
> > >problem
> > >and emitted the message?
> > >
> > >In the past I've had cases where the branch needed to be rebased
> > >to
> > >current master, but that does not seem to be sufficient with
> > >these:
> > >
> > >https://github.com/openshift/li/pull/916
> > >
> > >https://github.com/openshift/origin-server/pull/1436
> > 
> > I thought maybe there was some case in which github and our bot
> > could
> > disagree about the automergeability but looking in
> > git://github.com/openshift/test-pull-requests.git it seems like all
> > we
> > do is call github.  From the test-pull-requests code though it does
> > seem like there are some problems with their mergeability logic.
> > 
> > Following github's instructions on how to manually merge doesn't
> > return any conflict for me.  However I'm fairly certain github has
> > their own git implementation and you could very well be hitting a
> > bug
> > on there in.
> > 
> > I would suggest following up with github.
> > https://help.github.com/contact
> 
> Brenton is correct the github api can be a little flaky especially in
> regards to mergeability.  Just looking over the history of 1436 I
> see:
> 
> Evaluated up to f52a752
> Evaluated up to 7fb0a2b
> Evaluated up to 2f2339d
> Evaluated up to d4ffc0d
> 
> So those are all because you are rewriting your commit and repushing
> it.
> 
> And it appears 3 times over 7 days github told us the pull wasn't
> mergeable.
> 
> -Dan
> 
> > 
> > >
> > >I'm guessing there's something I should have read that I missed.
> > >
> > >Any guidance appreciated.
> > >
> > >- Mark
> > >
> > >
> > >--
> > >Mark Lamourine <markllama redhat com>
> > >Sr. Software Developer, Cloud Engineering
> > >Red Hat, 314 Littleton Road, Westford MA 01886
> > >Voice: +1 978 392 1093
> > >http://people.redhat.com/~mlamouri
> > >markllama @ irc://irc.freenod.org*lopsa
> > >
> > >_______________________________________________
> > >dev mailing list
> > >dev lists openshift redhat com
> > >http://lists.openshift.redhat.com/openshiftmm/listinfo/dev
> > 
> > _______________________________________________
> > dev mailing list
> > dev lists openshift redhat com
> > http://lists.openshift.redhat.com/openshiftmm/listinfo/dev
> > 
> 
> _______________________________________________
> dev mailing list
> dev lists openshift redhat com
> http://lists.openshift.redhat.com/openshiftmm/listinfo/dev
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]