[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: disable cgroups pull requests: resolution?




----- Original Message -----
> From QE side, we often leave cgroups in default settings, and did not
> meet the warning message when we run oo-accept-node last time.
> 
> -xiaoli

Xiaoli:

You probably haven't seen any warning because the updated oo-accept-node which would emit it hasn't been accepted yet.

The issue I have with getting these three pull requests merged is that the updated accept-node won't pass until the updated test that will accept "PASS" with warnings hasn't been merged yet.  The origin-dev-tools and li pull requests must pass and merge first.  It's not clear to me if they have mutual dependency failure too.

I just got a note from one indicating that I've put in cross dependencies in the pull requests that complicate things more:

> User 'markllama' is not permitted to test linked pull request 36 in 'origin-dev-tools'. If the test was requested by another user
> with permission to test in 'origin-dev-tools', the linked pull request must be in a comment before the test comment (not including
> the pull request description) or be added by a user with permission to test in 'origin-dev-tools'.

I'm thinking I need to close the existing pull requests and submit the test updates to li and origin-dev-tools first, one at a time and then re-submit the update to oo-accept-node.

Suggestions?

- Mark
> 
> 
> ----- Original Message -----
> > Ops and QE
> > 
> > Does any of your automation run with cgroups off?  If so, does it
> > depend on oo-accept-node returning just ^PASS$ vs. having the
> > additional warning about cgroups being turned off?
> > 
> > /jwh
> > 
> > 
> > ----- Original Message -----
> > > From: "Mark Lamourine" <markllama redhat com>
> > > To: "Openshift Dev" <dev lists openshift redhat com>
> > > Sent: Thursday, March 14, 2013 7:15:23 AM
> > > Subject: disable cgroups pull requests: resolution?
> > > 
> > > I have three related pull requests outstanding related to
> > > optional
> > > cgroups:
> > > 
> > > 
> > > 1) https://github.com/openshift/origin-dev-tools/pull/36
> > > 
> > >   Allow accept-node to pass with warnings
> > > 
> > > 2) https://github.com/openshift/li/pull/916
> > > 
> > >   Allow accept-node to pass with warnings
> > > 
> > > 3) https://github.com/openshift/origin-server/pull/1436
> > > 
> > >   Enable/Disable cgroups in /etc/openshift/node.conf.
> > >    accept-node
> > >   warns when disabled.
> > > 
> > > Unfortunately they're in a chicken-egg state I think.
> > > 
> > > The problem stems from two factors:
> > >   * I insisted on putting a warning in oo-accept-node if cgroups
> > >   is
> > >   disabled
> > >   * The tests in origin-dev-tools and li only accept "^PASS$" as
> > >   output from oo-accept-node.
> > > 
> > > If I can get the first two pull requests merged, then the third
> > > will
> > > pass.
> > > 
> > > The original reason for these was that cgroups on F18 were
> > > causing
> > > kernel panics. Krishna needed a way to proceed without it
> > > blocking,
> > > but the kernel folks were quicker than me.
> > > 
> > > I've rebased all three to current one last time.  Should I just
> > > cancel them? How would I get them accepted in order so that they
> > > will all pass?
> > > 
> > > Is it still needed?
> > > 
> > > - Mark
> > > 
> > > --
> > > Mark Lamourine <markllama redhat com>
> > > Sr. Software Developer, Cloud Engineering
> > > Red Hat, 314 Littleton Road, Westford MA 01886
> > > Voice: +1 978 392 1093
> > > http://people.redhat.com/~mlamouri
> > > markllama @ irc://irc.freenod.org*lopsa
> > > 
> > > _______________________________________________
> > > dev mailing list
> > > dev lists openshift redhat com
> > > http://lists.openshift.redhat.com/openshiftmm/listinfo/dev
> > > 
> > 
> > 
> 
> --
> 
> -xiaoli
> 
> 
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]