[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Any reason why user action hooks have to be +x?



----- Original Message -----
> From: "Dan Mace" <dmace redhat com>
> To: "Clayton Coleman" <ccoleman redhat com>
> Cc: dev lists openshift redhat com
> Sent: Tuesday, September 3, 2013 9:26:35 AM
> Subject: Re: Any reason why user action hooks have to be +x?
> 
> I can't remember the arguments against setting the modes on the user's behalf
> (or working around the modes another way to make them irrelevant) when this
> came up in the past leading to the current design/documentation. I'm in
> favor of finding some way to eliminate the mode requirement. I can't think
> of any reason we should support a case where the user commits a
> non-executable script to the hooks directory that they intend to be ignored
> simply due to the mode (e.g. if you want to commit but disable the hook,
> rename or move it).
> 

As a general rule, we shouldn't be executing scripts that are not set executable.  I get that this is confusing to new users, but the current setup is behaving as expected.  I think I would prefer a louder note when a script is found that is not executable.

=====
NOTE:  .openshift/action_hooks/start is not executable and so OpenShift has skipped it.
Please chmod +x .openshift/action_hooks/start to start it
=====

Or something to that effect.  It's just a common convention and one worth observing.

    -Mike


> --
> Dan Mace
> Sr. Software Engineer, Red Hat
> 
> 
> ----- Original Message -----
> > From: "Clayton Coleman" <ccoleman redhat com>
> > To: dev lists openshift redhat com
> > Sent: Tuesday, September 3, 2013 10:22:12 AM
> > Subject: Any reason why user action hooks have to be +x?
> > 
> > Thinking through this... we've had a number of folks who hit the old "oops,
> > my action hooks aren't +x".  Since we are no longer including the hooks in
> > cart templates, it makes it more likely a new user is going to end up
> > wasting their time trying to fix an arbitrary problem (it's burned even
> > experienced developers).  Also, windows developers can't even easily fix
> > modes - requires some git knowledge.
> > 
> > Is there a good reason we can't just "/bin/sh" each hook directly or auto
> > +x
> > it?  Or auto +x during deployment?
> > 
> > I vaguely remember discussions, would like to have a discussion on it.
> > 
> > _______________________________________________
> > dev mailing list
> > dev lists openshift redhat com
> > http://lists.openshift.redhat.com/openshiftmm/listinfo/dev
> > 
> 
> _______________________________________________
> dev mailing list
> dev lists openshift redhat com
> http://lists.openshift.redhat.com/openshiftmm/listinfo/dev
> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]