|Master of Puppets|
|+55 (51) 8298.0026|
|gtalk: mateus caruccio getupcloud com|
|This message and any attachment are solely for the intended|
recipient and may contain confidential or privileged information
and it can not be forwarded or shared without permission.
Thanks for creating the cartridge!
Here are some initial review comments:
1. Move the password generation and client_result from setup into a separate install script, since setup is meant to be called
again during migrations and install is a one time script that is called when a cartridge is first installed.
2. It might make sense to add a OPENSHIFT_MEMCACHED_VERSION environment variable and use that, so it will be easier to add support for
newer versions in the future. (See https://github.com/openshift/origin-server/blob/master/cartridges/openshift-origin-cartridge-python/bin/install.)
3. The best place to put binaries is under usr/ directory, so you could move your binaries to usr/versions/1.4.15/bin.
The reason is that for non-downloadable cartridges, the usr/ directory is shared among all users to save disk space.
(It will help if we were to make this a first class cartridge at some point.)
I will inspect the scripts in more detail and reply with more comments, if any, later.
----- Original Message -----
> From: "Mateus Caruccio" <mateus caruccio getupcloud com>
> To: dev lists openshift redhat com
> Sent: Monday, September 2, 2013 5:38:54 PM
> Subject: Memcached cartridge
> Hi everyone.
> I've built this memcached cartridge. It is pretty initial code, heavilly
> based upon github.com/brianredbeard/openshift-cartridges and
> It's hosted on github.com/getupcloud/openshift-origin-cartridge-memcached ,
> with builds served by memcached-caruccio.getup.io/
> The cart adds sasl support (memcached binary protocol only), so it's safe to
> deploy on a dedicated gear. My goal is to allow instant apps like wordpress
> to auto-scale while benefiting from the use of memcached.
> I appreciate if someone could review it and give some advice/suggestion/PR
> since this is my very first cart.
> Mateus Caruccio
> dev mailing list
> dev lists openshift redhat com