[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Need help with pull request and testing



Hi,

Sorry, I'm new to git it seems two of the files and my last changes didn't get pushed. I've now uploaded them, do I need to close my pull request and resubmit it?

Thank you for your help.

Cheers,
Andrew.


On Fri, Jan 10, 2014 at 1:03 AM, N. Harrison Ripps <hripps redhat com> wrote:
Hey Andrew--
I'm going to review this now; if I have any questions I'll add them to the pull request.

Thanks for the submission!
Harrison

On Jan 9, 2014, at 7:47 , <andrew andrewklau com> <andrew andrewklau com> wrote:

> Thanks for the suggestion.
>
> From: Mateus Caruccio
> Sent: Thursday, January 9, 2014 11:41 PM
> To: Andrew Lau
> Cc: users
>
> +1
>
> However, I think you should send this message to dev lists openshift redhat com
>
> Mateus Caruccio
> Master of Puppets
> +55 (51) 8298.0026
> gtalk: mateus caruccio getupcloud com
> twitter: @MateusCaruccio
>
> This message and any attachment are solely for the intended
> recipient and may contain confidential or privileged information
> and it can not be forwarded or shared without permission.
> Thank you!
>
>
> On Thu, Jan 9, 2014 at 10:19 AM, Andrew Lau <andrew andrewklau com> wrote:
> Hi all,
>
> I'd like to use MariaDB in my openshift deployment so I made an attempt to submit a pull request https://github.com/openshift/origin-server/pull/4395
>
> It hasn't been accepted yet, and I assume it's because I have not been able to test it. Can someone link me to the procedures on how to test and submit a proper pull request so it can be built? Pretty please :)
>
> Cheers,
> Andrew.
>
>
>
> _______________________________________________
> users mailing list
> users lists openshift redhat com
> http://lists.openshift.redhat.com/openshiftmm/listinfo/users
>
>
>
> _______________________________________________
> dev mailing list
> dev lists openshift redhat com
> http://lists.openshift.redhat.com/openshiftmm/listinfo/dev



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]