[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Fwd: Ask for ideas about bug 1162474



+++ Zamir Sun [11/11/14 16:32 +0800]:
Hi Openshift Developers,

I saw the bug 1162474[1] which is caused by the code do not check the
app_name. I want to commit my fix to this, but as I dive in, I find
that the broker-util/oo-admin-upgrade just only parse the app_name
from command line to the result gear.
So now I am thinking of two ways to fix. One is just omit the app_name
from the command line and use the app name find by uuid. I've posted
my code here[2]. And the second is to check the app_name with app.name
which I fixed here[3].
So I want to hear your ideas before make a pull request.

Thanks.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1162474
[2] https://github.com/sztsian/origin-server/commit/90b2a1b90efe07adc304f68a9215203a1b593547
[3] https://github.com/sztsian/origin-server/commit/80a88b62947bd730d54621f56d95a8e7dff02f46

Hi Zamir,

When I first looked at the code it definitely seemed strange that we
would have an option to pass in the application name for the
'upgrade-gear' command even though we don't really use it.

I suspect the original intention of passing in both the login name and
the application was to provide admins better output in the event an
upgrade failure.  They could tell develers app 'foo' had problems
instead of referring to it by a uuid that no one could remember.

My preference would be to add the logic to verify that the app name
passed in matches the name that was returned from find_by_uuid.

--Brenton


_______________________________________________
dev mailing list
dev lists openshift redhat com
http://lists.openshift.redhat.com/openshiftmm/listinfo/dev


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]