[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: oo-admin-geartop



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/11/2014 10:07 AM, Jason DeTiberus wrote:
> On 10/09/14 17:59 -0400, Scott Dodson wrote:
>> This[1] is an updated version of the geartop[2] script that
>> Kenny Woodson and Andy Grimm put together a few months ago.
>> 
>> Changes from the original : ** obtains uid ranges from config
> 
> The uid values in /etc/openshift/node.conf are only used on 
> non-districted nodes (and we now require districts for all
> installations as of ose 2.1). You will only want to use those
> values if the node doesn't belong to a district. I added support
> for this to oo-accept-node a while back 
> (https://github.com/openshift/origin-server/blob/master/node-util/sbin/oo-accept-node#L443-L453)
>
> 
> 
>> ** accepts command line args for interval, iterations, and sort
>> order ** renamed to oo-admin-geartop
>> 
>> I wanted it to be discoverable via tab completion but I'm not
>> sure oo-admin-geartop is the best name, suggestions? Feedback
>> welcome.
> 
> You may want to submit a PR for feedback, makes it easier to
> comment on specific sections of code.  You can prefix the PR with
> [DO NOT MERGE] to make the intent clear that it is for feedback.

Thanks Jason, I've updated the uid lookup function to work properly on
districted nodes per your suggestion.

https://github.com/openshift/origin-server/pull/5806

- --
Scott
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAEBAgAGBQJUEejUAAoJEMRr2CP2Mq29jrgH/iVybTi4OiEqPYPQvXUqEgHx
5Iz8JQq5K+0hL2WJnFhsRerMaYxm5Pdxv2lmC/5GXaZLdrlnzQsAAyhau2jKSCL5
uZ1rYVWCdWCnRF2OwO4GWZ52O+xLodHyYR7LpM/TsizDzraZ9LfxLgzOf0F8fTBb
j95EYtU8+gNgXBwISbt6OqWwJlnZEnr6wOMZmX6F+iJvzNAV+75r42RFWElDFuqg
IPxws9uq3/bUK2r7+b+RnwvjqP4CCctWVeOeFEUASGGxiXqOZsAHX94QG9UO7wVm
0w0Krh2KPb8BSCgUhP9EUv045HlcMMvXJnKHOtSfyeD8OR/VhI06OkhqFyZNlEA=
=2pkp
-----END PGP SIGNATURE-----


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]