[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Command to install / check registry



Implement our own, I think.  We shouldn't be patching things in cobra that wouldn't get fixed, and I'm not sure cobra would accept that patch.  However, it doesn't hurt to propose the change.


On Feb 26, 2015, at 3:03 PM, Fabiano Franz <ffranz redhat com> wrote:

>> Fabiano can override the template maybe.  It might be coming from Go's printf
>> %q format though.
> 
> Correct, it uses fmt %d:
> 
> https://github.com/spf13/pflag/blob/master/flag.go#L280
> 
> Options are 1) to patch FlagUsages() in Cobra, 2) do a simple replace s/"/' in our template where we call FlagUsages() or 3) simply not use FlagUsages() and implement our own function to print flags in the templates. 
> 
> Preferences?
> 
> Fabiano Franz
> 
> 
>> 
>>> On Feb 24, 2015, at 7:26 AM, Luke Meyer <lmeyer redhat com> wrote:
>>> 
>>> Actually I think cobra is filling in those quotes automatically for flag
>>> descriptions. I don't know that there's any way to tell it to use single
>>> instead of double...? I'll look, but if anyone has a pointer...
>>> 
>>> ----- Original Message -----
>>> From: "Clayton Coleman" <ccoleman redhat com>
>>> To: "Luke Meyer" <lmeyer redhat com>
>>> Cc: "Openshift Dev" <dev lists openshift redhat com>, ejacobs redhat com
>>> Sent: Monday, February 23, 2015 4:26:35 PM
>>> Subject: Re: Command to install / check registry
>>> 
>>> Can you do a pull?  Getting on a plane
>>> 
>>> 
>>>> On Feb 23, 2015, at 4:04 PM, Luke Meyer <lmeyer redhat com> wrote:
>>>> 
>>>> Prolly help if we fix the help. Many people actually do know how to cut
>>>> and paste...
>>>> 
>>>> ----- Original Message -----
>>>> From: "Clayton Coleman" <ccoleman redhat com>
>>>> To: ejacobs redhat com
>>>> Cc: "Openshift Dev" <dev lists openshift redhat com>
>>>> Sent: Monday, February 23, 2015 3:58:02 PM
>>>> Subject: Re: Command to install / check registry
>>>> 
>>>> I think that's going to be the number one problem people hit using this
>>>> format.  However, all the alternative formats (printf, golang template,
>>>> erb) are all more obscure and potentially confusing.
>>>> 
>>>> 
>>>>> On Feb 23, 2015, at 3:32 PM, Erik M Jacobs <ejacobs redhat com> wrote:
>>>>> 
>>>>> Damn you, quotes!
>>>>> 
>>>>> Erik M Jacobs, RHCA
>>>>> Principal Technical Marketing Manager, OpenShift Enterprise
>>>>> Red Hat, Inc.
>>>>> Phone: 646.462.3745
>>>>> Email: ejacobs redhat com
>>>>> AOL Instant Messenger: ejacobsatredhat
>>>>> Twitter: @ErikonOpen
>>>>> Freenode: thoraxe
>>>>> 
>>>>> 
>>>>>> On 02/23/2015 03:03 PM, Clayton Coleman wrote:
>>>>>> You are placing those in double quotes... which evaluates the variables
>>>>>> from bash.  Need to use single quotes.
>>>>>> 
>>>>>> ----- Original Message -----
>>>>>>> It still doesn't seem to work.
>>>>>>> 
>>>>>>> openshift ex router --help
>>>>>>> ...
>>>>>>> --images="openshift/origin-${component}:${version}": The image to base
>>>>>>> this router on - ${component} will be replaced with --type
>>>>>>> ...
>>>>>>> 
>>>>>>> openshift ex router --create --credentials=$KUBECONFIG
>>>>>>> --images="registry.access.redhat.com/openshift3_beta/ose-${component}:${version}"
>>>>>>> 
>>>>>>> router-1-6bqk4         10.1.0.8            router
>>>>>>> registry.access.redhat.com/openshift3_beta/ose-:
>>>>>>> ose3-master.example.com/192.168.133.2
>>>>>>> deployment=router-1,deploymentconfig=router
>>>>>>> ,router=router   Pending
>>>>>>> 
>>>>>>> So, either the help text is wrong, or something else is going wrong.
>>>>>>> with/without quotes doesn't seem to make a difference. My guess is that
>>>>>>> bash is trying to evaluate those variables but they are empty.
>>>>>>> 
>>>>>>> Erik M Jacobs, RHCA
>>>>>>> Principal Technical Marketing Manager, OpenShift Enterprise
>>>>>>> Red Hat, Inc.
>>>>>>> Phone: 646.462.3745
>>>>>>> Email: ejacobs redhat com
>>>>>>> AOL Instant Messenger: ejacobsatredhat
>>>>>>> Twitter: @ErikonOpen
>>>>>>> Freenode: thoraxe
>>>>>>> 
>>>>>>> 
>>>>>>>> On 02/23/2015 12:17 PM, Clayton Coleman wrote:
>>>>>>>> Yes... Those config files aren't config for OpenShift the binary.
>>>>>>>> 
>>>>>>>> 
>>>>>>>>> On Feb 23, 2015, at 12:06 PM, Erik M Jacobs <ejacobs redhat com>
>>>>>>>>> wrote:
>>>>>>>>> 
>>>>>>>>> Hi Clayton,
>>>>>>>>> 
>>>>>>>>> Looks like ex router ignores the config files:
>>>>>>>>> 
>>>>>>>>> # openshift ex router --create --credentials=$KUBECONFIG
>>>>>>>>> 
>>>>>>>>> router-1-r6r30         10.1.0.3            router
>>>>>>>>> openshift/origin-haproxy-router:v0.3.2
>>>>>>>>> ose3-master.example.com/192.168.133.2
>>>>>>>>> deployment=router-1,deploymentconfig=router,router=router   Pending
>>>>>>>>> 
>>>>>>>>> [root ose3-master training]# cat /etc/sysconfig/openshift-master |
>>>>>>>>> grep
>>>>>>>>> -i images
>>>>>>>>> IMAGES=registry.access.redhat.com/openshift3_beta/ose-${component}:${version}
>>>>>>>>> [root ose3-master training]# cat /etc/sysconfig/openshift-node | grep
>>>>>>>>> -i
>>>>>>>>> images
>>>>>>>>> IMAGES=registry.access.redhat.com/openshift3_beta/ose-${component}:${version}
>>>>>>>>> 
>>>>>>>>> Erik M Jacobs, RHCA
>>>>>>>>> Principal Technical Marketing Manager, OpenShift Enterprise
>>>>>>>>> Red Hat, Inc.
>>>>>>>>> Phone: 646.462.3745
>>>>>>>>> Email: ejacobs redhat com
>>>>>>>>> AOL Instant Messenger: ejacobsatredhat
>>>>>>>>> Twitter: @ErikonOpen
>>>>>>>>> Freenode: thoraxe
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>>> On 02/23/2015 09:56 AM, Clayton Coleman wrote:
>>>>>>>>>> Like router, yes.  That's why the name changed.
>>>>>>>>>> 
>>>>>>>>>> ----- Original Message -----
>>>>>>>>>>> I am hoping that this change uses the configured IMAGES formatting
>>>>>>>>>>> and
>>>>>>>>>>> is not hardcoded to openshift/origin-docker-registry ?
>>>>>>>>>>> 
>>>>>>>>>>> Erik M Jacobs, RHCA
>>>>>>>>>>> Principal Technical Marketing Manager, OpenShift Enterprise
>>>>>>>>>>> Red Hat, Inc.
>>>>>>>>>>> Phone: 646.462.3745
>>>>>>>>>>> Email: ejacobs redhat com
>>>>>>>>>>> AOL Instant Messenger: ejacobsatredhat
>>>>>>>>>>> Twitter: @ErikonOpen
>>>>>>>>>>> Freenode: thoraxe
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>>> On 02/22/2015 06:32 PM, Clayton Coleman wrote:
>>>>>>>>>>>> https://github.com/openshift/origin/pull/1100 adds a command to
>>>>>>>>>>>> install
>>>>>>>>>>>> or
>>>>>>>>>>>> check the integrated Docker registry which is installed as a
>>>>>>>>>>>> service
>>>>>>>>>>>> "docker-registry" in the default namespace.
>>>>>>>>>>>> 
>>>>>>>>>>>> To run
>>>>>>>>>>>> 
>>>>>>>>>>>> $ openshift ex registry --create
>>>>>>>>>>>> --credentials=<path_to_registry_credentials>
>>>>>>>>>>>> 
>>>>>>>>>>>> Like the router, the default "openshift-client" credentials should
>>>>>>>>>>>> be
>>>>>>>>>>>> sufficient for the registry.  Unlike the router, we don't support
>>>>>>>>>>>> at
>>>>>>>>>>>> this
>>>>>>>>>>>> time installing more than one integrated registry, so no argument
>>>>>>>>>>>> for a
>>>>>>>>>>>> registry name is accepted.  Once you've created your registry you
>>>>>>>>>>>> can
>>>>>>>>>>>> check the status of the registry via:
>>>>>>>>>>>> 
>>>>>>>>>>>> # have pods been registered to the service as endpoints?
>>>>>>>>>>>> $ osc get service docker-registry
>>>>>>>>>>>> 
>>>>>>>>>>>> # has the registry been deployed?
>>>>>>>>>>>> $ osc get dc docker-registry
>>>>>>>>>>>> 
>>>>>>>>>>>> Note: this change also switches from using the image name
>>>>>>>>>>>> "openshift/docker-registry" to "openshift/origin-docker-registry"
>>>>>>>>>>>> for
>>>>>>>>>>>> the
>>>>>>>>>>>> registry to be compatible with the default naming scheme.
>>>>>>>>>>>> hack/install-registry.sh has been removed, and the end to end test
>>>>>>>>>>>> and
>>>>>>>>>>>> documentation updated.  In the end-to-end test, the registry port
>>>>>>>>>>>> is
>>>>>>>>>>>> now
>>>>>>>>>>>> 5000 by default (eventually, we will switch to 443 and enforce
>>>>>>>>>>>> https).
>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>>> ----- Original Message -----
>>>>>>>>>>>>> Now that more of the authentication and authorization pieces are
>>>>>>>>>>>>> integrated,
>>>>>>>>>>>>> we wanted to make setting up and configuring bits of the
>>>>>>>>>>>>> OpenShift
>>>>>>>>>>>>> infrastructure easier.  The first step is
>>>>>>>>>>>>> https://github.com/openshift/origin/pull/1043 which adds a new
>>>>>>>>>>>>> command:
>>>>>>>>>>>>> 
>>>>>>>>>>>>> openshift ex router
>>>>>>>>>>>>> 
>>>>>>>>>>>>> (ex is for experimental, i.e. an alpha command).
>>>>>>>>>>>>> 
>>>>>>>>>>>>> This is an admin level command that can check for an installed
>>>>>>>>>>>>> router,
>>>>>>>>>>>>> install one for you, help you templatize your routers (if you
>>>>>>>>>>>>> want to
>>>>>>>>>>>>> tweak
>>>>>>>>>>>>> them), and load the necessary credentials for the router into the
>>>>>>>>>>>>> definition.
>>>>>>>>>>>>> 
>>>>>>>>>>>>> To check your router, run:
>>>>>>>>>>>>> 
>>>>>>>>>>>>> $ openshift ex router
>>>>>>>>>>>>> 
>>>>>>>>>>>>> It will look for a service called "router" in the default (or
>>>>>>>>>>>>> current)
>>>>>>>>>>>>> namespace.  If it doesn't find one, it'll tell you:
>>>>>>>>>>>>> 
>>>>>>>>>>>>> $ openshift ex router
>>>>>>>>>>>>> 
>>>>>>>>>>>>> If you pass the '--create' flag OpenShift will generate a
>>>>>>>>>>>>> deployment
>>>>>>>>>>>>> config
>>>>>>>>>>>>> and a service for you based on a few flags - see the help for
>>>>>>>>>>>>> more
>>>>>>>>>>>>> details.
>>>>>>>>>>>>> You need to give the router the credentials it will use to
>>>>>>>>>>>>> authenticate to
>>>>>>>>>>>>> the master - you can do that by passing --credentials with a path
>>>>>>>>>>>>> to a
>>>>>>>>>>>>> .kubeconfig file.  The "openshift-client" kubeconfig has the
>>>>>>>>>>>>> right
>>>>>>>>>>>>> level
>>>>>>>>>>>>> of
>>>>>>>>>>>>> access.  To see what would be generated pass "-o yaml" (same as
>>>>>>>>>>>>> you
>>>>>>>>>>>>> would
>>>>>>>>>>>>> to
>>>>>>>>>>>>> osc get):
>>>>>>>>>>>>> 
>>>>>>>>>>>>> $ openshift ex router
>>>>>>>>>>>>> --credentials="<certdir>/openshift-client/.kubeconfig" -o yaml
>>>>>>>>>>>>> .... yaml describing the router
>>>>>>>>>>>>> 
>>>>>>>>>>>>> If you like what you see, replace `-o yaml` with `--create` (or
>>>>>>>>>>>>> redirect
>>>>>>>>>>>>> it
>>>>>>>>>>>>> to a file, edit it, then cat it to `osc create -f -`):
>>>>>>>>>>>>> 
>>>>>>>>>>>>> $ openshift ex router
>>>>>>>>>>>>> --credentials="<certdir>/openshift-client/.kubeconfig" --create
>>>>>>>>>>>>> router
>>>>>>>>>>>>> router
>>>>>>>>>>>>> 
>>>>>>>>>>>>> That's a service and a deployment config:
>>>>>>>>>>>>> 
>>>>>>>>>>>>> $ osc describe dc router
>>>>>>>>>>>>> 
>>>>>>>>>>>>> The router will spin up and create a pod.  Because it's a
>>>>>>>>>>>>> deployment
>>>>>>>>>>>>> config,
>>>>>>>>>>>>> you can now roll out config changes or scale it up.
>>>>>>>>>>>>> 
>>>>>>>>>>>>> You can also create named routers by giving `openshift ex router`
>>>>>>>>>>>>> an
>>>>>>>>>>>>> argument:
>>>>>>>>>>>>> 
>>>>>>>>>>>>> $ openshift ex router myrouter-west --replicas=2 ...
>>>>>>>>>>>>> 
>>>>>>>>>>>>> The router command is just a simple generator right now - as we
>>>>>>>>>>>>> have
>>>>>>>>>>>>> more
>>>>>>>>>>>>> pieces of the infrastructure in place you should see more
>>>>>>>>>>>>> sophistication
>>>>>>>>>>>>> (like assigning your routers to an infrastructure zone, or
>>>>>>>>>>>>> defining
>>>>>>>>>>>>> shards).
>>>>>>>>>>>>> 
>>>>>>>>>>>>> Up next - the registry.
>>>>>>>>>>>> 
>>>>>>>>>>>> _______________________________________________
>>>>>>>>>>>> dev mailing list
>>>>>>>>>>>> dev lists openshift redhat com
>>>>>>>>>>>> http://lists.openshift.redhat.com/openshiftmm/listinfo/dev
>>>> 
>>>> _______________________________________________
>>>> dev mailing list
>>>> dev lists openshift redhat com
>>>> http://lists.openshift.redhat.com/openshiftmm/listinfo/dev
>> 
>> _______________________________________________
>> dev mailing list
>> dev lists openshift redhat com
>> http://lists.openshift.redhat.com/openshiftmm/listinfo/dev
>> 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]