[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: oc env/oc volume in oc help?



nevermind, it's all in the help string this has been moved to "oc set" prefix

On Wed, May 11, 2016 at 7:59 AM, Chmouel Boudjnah <chmouel redhat com> wrote:
> Hello,
>
> For some zsh oc auto completion project we are using "oc help" to
> generate the completion command.
>
> I was suprised to don't see "oc env" and "oc volume" in there and
> looking at the code I see :
>
> https://github.com/openshift/origin/blob/4537aad61b6b6ba98a4e5a09df6928dea03bfa70/pkg/cmd/cli/cli.go#L172-L175
>
> // These commands are deprecated and should not appear in help
> moved(fullName, "set env", cmds, set.NewCmdEnv(fullName, f, in, out)),
> moved(fullName, "set volume", cmds, set.NewCmdVolume(fullName, f, out, errout)),
> moved(fullName, "logs", cmds, cmd.NewCmdBuildLogs(fullName, f, out)),
>
> is it "oc set env/set volume" deprecated?, would that be ok if I send
> a patch to just add those command back in for example "Application
> Management Commands" group?
>
> Chmouel
>
> [1] https://github.com/chmouel/oh-my-zsh-openshift: could not find a
> way to get bash-completions to work under zsh or have cobra supporting
> properly zsh


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]