[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: 3.6.1 test failures



On 2017-11-02 16:29, Neale Ferguson wrote:
> coverage: 75.9% of statements
> 
> FAIL    github.com/openshift/origin/pkg/build/cmd       0.124s
> 
> 
> - It appears there are more ciphers supported in this level of go (1.8.1
> - defined in /usr/lib/golang/src/crypto/tls/cipher_suites.go) than
> openshift is prepared to use. I assume
> updating pkg/cmd/server/crypto/crypto.go with these additional ciphers
> would be required (among other places):
> 
> --- FAIL: TestConstantMaps (0.02s)
> 
>         crypto_test.go:35: discovered cipher
> tls.TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305 not in ciphers map
> 
>         crypto_test.go:35: discovered cipher
> tls.TLS_RSA_WITH_AES_128_CBC_SHA256 not in ciphers map
> 
>         crypto_test.go:35: discovered cipher
> tls.TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305 not in ciphers map
> 
>         crypto_test.go:35: discovered cipher
> tls.TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256 not in ciphers map
> 
>         crypto_test.go:35: discovered cipher
> tls.TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256 not in ciphers map
> 
> Building CA...
> 
> Building intermediate 1...
> 
> Building intermediate 2...
> 
> Building server...
> 
> Building client...
> 
> FAIL
> 
> coverage: 12.7% of statements
> 
> FAIL    github.com/openshift/origin/pkg/cmd/server/crypto       1.857s

Your assumption is correct. The five ciphers were added to the cipher
map in
https://github.com/tiran/origin/commit/6da689b0f307474ed5733a7c3c739bfb6599b6e0
. The test assumes Golang 1.7.

Christian

-- 
Christian Heimes
Senior Software Engineer, Identity Management and Platform Security

Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael Cunningham, Michael
O'Neill, Eric Shander

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]